This repository has been archived by the owner on Jun 11, 2021. It is now read-only.
[google_sign_in_dart] Null safety migration #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed wrong assignment of _tokenExpiry to "token"
|
Update target branch to dev per request |
|
@long1eu Have you had a chance to review this yet? |
kevinlinnebur
approved these changes
May 15, 2021
long1eu
approved these changes
May 15, 2021
kevinlinnebur
approved these changes
May 15, 2021
| if (isDesktop) { | ||
| GoogleSignInPlatform.register(clientId: <clientId>); |
This was referenced May 21, 2021
Closed
|
The pull request will solve issue #28 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.0.9@long1eu I would appreciate a review on this please.